Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for F# SDK 10.1 #1857

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Conversation

ovatsus
Copy link

@ovatsus ovatsus commented Apr 9, 2018

closes #1855

@ovatsus
Copy link
Author

ovatsus commented Apr 9, 2018

Would be great if you could release this soon

@matthid
Copy link
Member

matthid commented Apr 9, 2018

I already pinged @forki . Problem is that I never managed to get the fake 4 release working on my system :/

@matthid
Copy link
Member

matthid commented Apr 9, 2018

But I will release this probably as part of 5.0.0-rc002 later today / soon

@matthid
Copy link
Member

matthid commented Apr 10, 2018

This is released in fake 5. The fake 4 hotfix will hopefully follow tomorrow. But you might consider upgrading ;)

@ovatsus
Copy link
Author

ovatsus commented Apr 10, 2018

I'll hold off upgrading to FAKE 5 for now, already too much yak shaving in the last couple of days :)

@matthid
Copy link
Member

matthid commented Apr 10, 2018

@ovatsus First step of the migration (ie upgrading to the 5.0 nuget package) should be harmless in any case. If not that would be a bug. But you will get a lot of warnings ;) - which could be disabled via fsiargs

@ovatsus
Copy link
Author

ovatsus commented Apr 10, 2018

Ok, you were right, it was easy (fsprojects/FSharp.Data#1150), but yikes so many warnings. Why did everything change? :)

@ovatsus
Copy link
Author

ovatsus commented Apr 10, 2018

Now just need someone to fix all the warnings (hint hint :p) fsprojects/FSharp.Data#1151

@forki forki merged commit 338837b into fsprojects:hotfix_fake4 Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants