Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonarqube migration #1583

Merged
merged 5 commits into from
Jun 11, 2017
Merged

Sonarqube migration #1583

merged 5 commits into from
Jun 11, 2017

Conversation

laedit
Copy link
Contributor

@laedit laedit commented Jun 10, 2017

I was trying to migrate SonarQubeHelper to FAKE 5, but I can't use Fake-netcore.sln: I got this error: Unrecognized Guid format..

So I made it all by hand and I got the following error on build:

FS0039: D:\prog\github\fake\src\app\Fake.Testing.SonarQube\SonarQube.fs(15,15): The namespace 'Core' is not defined.

Can you help me to finish this?

@matthid
Copy link
Member

matthid commented Jun 10, 2017

Oh yeah sure.
First: I don't even use Fake-netcore.sln myself, it's there just to make building steps in FAKE easier (and faster actually).
Usually what I do is:

  • Copy one of the existing netcore projects and edit the project file by hand.
  • Copy the old implementation files (update project file again if required)
  • Reference the new files in FakeLib (again updating FakeLib.fsproj by hand to properly reference the stuff)
  • Open Fake.sln and go from there. Because in F# you can only reference stuff defines in files ABOVE, this is ALMOST perfect
  • Once stuff compiles in the (Fake.sln) solution the remaining changes to make the netcore project compile are usually straightforward (you basically only need to fix project references or add framework nuget packages if needed)

Thanks for bringing that to my attention, will add that to the docs somewhere.
Let me know if that actually helps.

@laedit
Copy link
Contributor Author

laedit commented Jun 11, 2017

Thanks, I have already did the first three but haven't though of continuing with Fake.sln! 😄

It should be all good now.

@laedit laedit changed the title [WIP] Sonarqube migration Sonarqube migration Jun 11, 2017
@laedit
Copy link
Contributor Author

laedit commented Jun 11, 2017

It seems that Travis is struggling during DotnetPack but I don't know why.

@matthid
Copy link
Member

matthid commented Jun 11, 2017

Yes mono is broken, don't worry about it. (fsprojects/Paket#2393)

Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect :)

@@ -66,7 +66,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "help", "help", "{564BD198-0
help\nuget.md = help\nuget.md
help\octopusdeploy.md = help\octopusdeploy.md
help\slacknotification.md = help\slacknotification.md
help\sonarcube.md = help\sonarcube.md
help\specifictargets.md = help\specifictargets.md
help\teamcity.md = help\teamcity.md
help\typescript.md = help\typescript.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I should probably update those, as I moved them into a subfolder..

@matthid matthid merged commit fb73333 into fsprojects:master Jun 11, 2017
@laedit laedit deleted the SonarQube-migration branch June 11, 2017 10:58
@matthid
Copy link
Member

matthid commented Jun 12, 2017

Released in alpha010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants