-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve log integration with AppVeyor #1490
Conversation
5da43e9
to
9e0fc0e
Compare
9e0fc0e
to
85f8879
Compare
build is red. can you please check? |
@forki just looking at it now. I had tested the build on one of my projects and it works as I'd expect. The error is in one of the tests and relates to an invalid char - the char is part of the escape sequence for ANSI color codes. As they tests are running on AppVeyor, I guess |
MSpec outputs the results to HTML/XML and 0x1B is not a valid character
5b54d75
to
8e8098c
Compare
@forki Issue seemed to be that because we were essentially bootstrapping FAKE in the test, it determined we were running AppVeyor. Because of that, the ANSI color codes were written to the trace (per my change). MSpec reports all the test results to HTML, and the escape sequence contains a character that's not valid in HTML. I changed to essentially toggle that option off in the class that contained the failing spec in an |
Eurgh, my VS code settings have trimmed a load of whitespace in the files I've edited. If you want me to revert those, just shout. |
thanks! |
This should make logging work on appveyor
Update the PrintRunningOrder to mirror logic in #1490
There were a couple of fairly inconsequential and primarily cosmetic issues that I'd noticed when AppVeyor runs a FAKE build script.
At the start, FAKE calls
PrintDependencyGraph
. This is written as multipleLogMessages
, which the AppVeyor helper also writes to AppVeyor's message log in the Messages tab. There are two issues that arise from this:appveyor AddMessage
is included in a trace. This seems to be a little redundant:appveyor AddMessage
fails when the message is empty:The changes I've made address each of those points:
I've changed the dependency message to be written as a single multi-line message so this appears as a single message in the log on AppVeyor. This makes no difference when written to the console.
I've changed to disable tracing when sending a message to the AppVeyor message log.
I've changed to not send empty messages to the AppVeyor message log, avoiding the error that results.
I've added ANSI color code support and use this when we're running on AppVeyor. If other build servers have the same issue & support ANSI colors then perhaps this could be enabled for those too. I ran a quick test for all
ConsoleColor
values to show how these are rendered on AppVeyor: