fix exception when dotnet cli is not installed. #1332
Conversation
| @@ -1,5 +1,5 @@ | |||
| /// Contains a task which can be used to run dotnet CLI commands. | |||
| module Fake.DotNet | |||
| module Fake.DotNetCli | |||
There was a problem hiding this comment.
@forki Is this OK? Its a breaking change, but the thing is new and it's currently colliding with my dotnetcore branch.
I really would like to have the Fake.DotNet namespace.
There was a problem hiding this comment.
I think we only need to change that in chessie, argu and akka.net wire
There was a problem hiding this comment.
I will add a obsolete tag to make it a soft fail. We can then replace it later with whatever comes
There was a problem hiding this comment.
@forki as note, Fake.DotNetSdk is better as name (dotnet cli was the old name, in docs now is .net core sdk)
There was a problem hiding this comment.
sry, didint see this pr in time 😢
Np anyway, it's not that bad (i'd like more .net cli than .net sdk).
And maybe is going to change anyway, who knows 😄
There was a problem hiding this comment.
For example Fake.DotnetCoreSdk the real name 😄
There was a problem hiding this comment.
Yeah @forki projects move too fast to handle ;)
I think dotnetcli is fine (the tool is called 'dotnet' and it's a command line interface). No idea what ms is doing...
There was a problem hiding this comment.
They changed name after beta, 6 months ago.
I think we should try to use were possible to use the correct name.
That help new users, because it's easier to search docs.
That said I liked more dotnet cli a lot as name.
For example we should stop to say coreclr when we mean .net core ( coreclr+corefx).
See fsprojects/Argu#57 (comment)