Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve default npm path handling #1278

Merged
merged 1 commit into from
Jul 12, 2016

Conversation

krgn
Copy link
Contributor

@krgn krgn commented Jun 20, 2016

I added a test to check whether npm exists in /usr/bin as a standard location in addition to the existing default /usr/local/bin. Also, I changed the shebang of build.sh such that it uses /usr/bin/env bash instead of hard-coding the path to bash (which does not work on systems like NixOS).

@TheAngryByrd
Copy link
Contributor

Would it make more sense to try to use what's on the environments path first? Then maybe default to these?

@krgn
Copy link
Contributor Author

krgn commented Jun 20, 2016

Yes, that is really the better way to do it. Gimme a sec

@krgn
Copy link
Contributor Author

krgn commented Jun 20, 2016

It now attempts to extract the path via which on Unix systems, and sets the default to /usr/bin/npm if that is not possible for some reason.

@krgn krgn force-pushed the improve-default-npm-path-handling branch from 7376234 to 309a262 Compare June 20, 2016 21:18
@krgn krgn force-pushed the improve-default-npm-path-handling branch from 309a262 to f2ccb3a Compare June 20, 2016 21:47
@forki
Copy link
Member

forki commented Jul 12, 2016

cool thanks.

@forki forki merged commit f2ccb3a into fsprojects:master Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants