Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSBuildHelper: Add BuildWebsite(s)Config. #1230

Merged
merged 1 commit into from
May 11, 2016

Conversation

ianbattersby
Copy link
Contributor

Adds the ability to build websites with a configuration other than Debug.

Sorry it took so long to pull-request this @forki after our chat many months ago, completely slipped my mind!

@forki
Copy link
Member

forki commented May 6, 2016

Is this breaking?

@ianbattersby
Copy link
Contributor Author

Nope, should be backwards compatible, on purpose 👍

@ianbattersby
Copy link
Contributor Author

PS. I did change a parameter name on an existing method to be consistent, but given F# as I know it (and the signature otherwise being the same) I thought this was safe.

@forki
Copy link
Member

forki commented May 6, 2016

Good. Thanks. Will merge / release in Monday. If I get my Internet
connection back.
On May 6, 2016 11:37 AM, "Ian Battersby" [email protected] wrote:

Nope, should be backwards compatible, on purpose 👍


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1230 (comment)

@forki
Copy link
Member

forki commented May 6, 2016

Yes changing name is fine in fake. Changing types not so much...
On May 6, 2016 11:38 AM, "Ian Battersby" [email protected] wrote:

PS. I did change a parameter name on an existing method to be consistent,
but given F# as I know it (and the signature otherwise being the same) I
thought this was safe.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1230 (comment)

@forki forki merged commit 6f69799 into fsprojects:master May 11, 2016
@forki
Copy link
Member

forki commented May 11, 2016

cool. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants