Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WP] Added more comfortable types to WiXHelper, flagged old ones obsolete #1036

Merged
merged 1 commit into from
Dec 19, 2015

Conversation

DigitalFlow
Copy link
Contributor

Hey all,

I did some slight changes to the WiXHelper, so that WiX Features, Custom Actions and Custom Action Executions don't get passed around as concatenated strings, but as sequences of their types.
The old types and functions using them were flagged as obsolete.

@forki: Two questions remaining:
1: I have a module called "Test.Fake.Deploy.Web.WixHelper" which resides in \src\test\Test.Fake.Deploy.Web. It does not seem to be included in the solution, where would this go?
2: I'd like to contribute the minimal working example of a WiX Target as section to the github.io page (https://fsharp.github.io/FAKE/). Where can I add this section?
Edit: Ah found it, goes to /help.

Kind Regards

@DigitalFlow DigitalFlow force-pushed the feature/WiXAdditions branch 2 times, most recently from ca066f0 to 50d41dc Compare December 9, 2015 12:54
@DigitalFlow
Copy link
Contributor Author

Don't really get, why "C:\projects\fake\src\app\FakeLib\FSharpFormattingHelper.fs(43,23): error FS0971: Undefined value 'command : string'" is failing, saw that other Pull Requests are also failing with this issue.
Seems unrelated.

@DigitalFlow DigitalFlow force-pushed the feature/WiXAdditions branch 4 times, most recently from b68aa9a to baef53d Compare December 15, 2015 12:45
@DigitalFlow
Copy link
Contributor Author

Ok so the new types work pretty well, I'm already using them in some projects.
@forki: The minimal working example markdown is done too, is it automatically added to the page index?
I still don't know however, whether the tests are fine in Test.Fake.Deploy.Web (I guess not)?
Rest should be fine.

@@ -588,10 +923,11 @@ let generateWiXScript fileName =
<Media Id=\"1\" Cabinet=\"media1.cab\" EmbedCab=\"yes\" />

<Directory Id=\"TARGETDIR\" Name=\"SourceDir\">
<Directory Id=\"ProgramFilesFolder\" Name=\"ProgramFiles\">
<Directory Id=\"@Product.ProgramFilesFolder@\" Name=\"ProgramFiles\">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not experienced with WiX, but from other Directory entries, shouldn't the placeholder be put into Name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got it, it's only the placeholder for ProgramFilesFolder or ProgramFiles64Folder, never mind.

forki added a commit that referenced this pull request Dec 19, 2015
[WP] Added more comfortable types to WiXHelper, flagged old ones obsolete
@forki forki merged commit 2925607 into fsprojects:master Dec 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants