[WP] Added more comfortable types to WiXHelper, flagged old ones obsolete #1036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
I did some slight changes to the WiXHelper, so that WiX Features, Custom Actions and Custom Action Executions don't get passed around as concatenated strings, but as sequences of their types.
The old types and functions using them were flagged as obsolete.
@forki: Two questions remaining:
1: I have a module called "Test.Fake.Deploy.Web.WixHelper" which resides in \src\test\Test.Fake.Deploy.Web. It does not seem to be included in the solution, where would this go?
2: I'd like to contribute the minimal working example of a WiX Target as section to the github.io page (https://fsharp.github.io/FAKE/). Where can I add this section?
Edit: Ah found it, goes to /help.
Kind Regards