Fix build of VSIX template #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! This is all I need to be happy :-). How does FAKE find the MSBuild executable? Doors it end up using a different one? To make this a bit more general, could you change this to find the Program Files folder dynamically? I think there is a fairly easy way to do this and it would make the code more general (I suppose we might still be missing some cases, but I'm fine with that) |
|
Like this? I'm not sure how MSBuild discovery is done, probably @forki can help with that. |
|
This is perfect. Thanks! I'll merge & close this - though I'm still quite curious why this is happening :-) |
forki
added a commit
to fsprojects/FAKE
that referenced
this pull request
Apr 24, 2014
forki
added a commit
to fsprojects/FAKE
that referenced
this pull request
Apr 24, 2014
|
FAKE 2.14.12 should use the same path as proposed by @dungpa - could you please retry? |
Closed
|
Works beautifully! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #30.
I'm not VS SDK expert and not sure this is the fix you're looking for.
The reason might be that the build script picks up a wrong version of MSBuild (x86 vs x64). Setting the path explicitly in the environment variable fixes it.