Completing Paket conversion! #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that one of the test projects referenced RProvider even though it did not use it (which failed as R provider does not work on Travis at the moment). This fixes that, reruns "paket install", adds project order requirement (wihch was missing) to Deedle.Core.sln and also adds workaround to `rinterop.fsx` (which will be fixed once we update R provider).
|
Very cool. |
|
Now I just need to have a dinner break before I can get rid of the F# Data dependency, because Github thinks I did enough |
|
Yeah I already tried to ask @shiftkey if we can get an API key or something
|
|
Awesome!! |
This was referenced Dec 8, 2014
tpetricek
added a commit
that referenced
this pull request
Jan 14, 2015
Completing Paket conversion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the work started by @forki in #276.
As discussed in the other thread, this does not change anything about how Deedle is consumed (we still publish a NuGet package, with the same things as before).
However, this changes how we reference other packages. Rather than using NuGet directly, this uses it through Paket, but under the cover, it still gets the packages from NuGet.
The nice things about Paket (and why I would like to use it for Deedle are):
fsprojfiles - when we update a reference, we just runpaket installand that will update thefsprojfiles (so no more messing with<HintPath>elements by hand)packagesdo not contain version number in the folder name (this means we do not have to modify*.fsxfiles when we update a version of a referenced package).