Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharpFormat #637

Closed
5 tasks done
ShalokShalom opened this issue Jan 19, 2018 · 4 comments
Closed
5 tasks done

SharpFormat #637

ShalokShalom opened this issue Jan 19, 2018 · 4 comments

Comments

@ShalokShalom
Copy link

ShalokShalom commented Jan 19, 2018

Formatting Tool

I propose we implement a formatting tool which runs either manually or after a successful compilation.

The existing way of approaching this in F# is not existent.

Pros and Cons

The advantages of making this adjustment to F# are that we solve the "Indentation breaks copy and paste" and to appear standardized.

The Elm, Go, Elixir and other communities can tell maybe more about potential Pros.

There is not a single disadvantage, so far as I am concerned.

Extra information

Estimated cost (XS, S, M, L, XL, XXL):
Well, I am a newbie, so this is up to you.
Fill in whatever you decide to let it cost you ;)

Related suggestions: (put links to related suggestions here)
https://github.com/avh4/elm-format
https://blog.golang.org/go-fmt-your-code

Affidavit (please submit!)

Please tick this by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on stackoverflow) and I have searched StackOverflow for discussions of this issue
  • I have searched both open and closed suggestions on this site and believe this is not a duplicate
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it.

Please tick all that apply:

  • This is not a breaking change to the F# language design
  • I or my company would be willing to help implement and/or test this
@enricosada
Copy link

An existing tool already exists, dungpa/fantomas

There is a PR to integrate fantomas in FCS dotnet/fsharp#3542

as a note, this require #637 to allow to reformat comment in the right location

@ShalokShalom
Copy link
Author

This is 637? What do you mean with "reformat comment in the right location"?

@wallymathieu
Copy link

Looks like they have some things that needs to be fixed before merging.

@ShalokShalom
Copy link
Author

Now I got the sentence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants