add option to specify the location to store workspace-specific state #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
commented
Apr 7, 2022
| @@ -469,9 +469,10 @@ type BackgroundServiceServer(state: State, client: FsacClient) = | |||
| return LspResult.success () | |||
| } | |||
|
|
|||
| member __.InitWorkspace() = | |||
There was a problem hiding this comment.
instead of workspace context location being passed in during start (which doesn't pass any data to the launched background process), doing it during initworkspace makes a ton more sense to me.
| @@ -47,7 +49,8 @@ type State = | |||
| CancellationTokens = ConcurrentDictionary() | |||
| NavigationDeclarations = ConcurrentDictionary() | |||
| ScriptProjectOptions = ConcurrentDictionary() | |||
| ColorizationOutput = false } | |||
| ColorizationOutput = false | |||
| WorkspaceStateDirectory = workspaceStateDir } | |||
There was a problem hiding this comment.
it made sense to put this on State for easy access, since State is our central location for workspace state
baronfel
force-pushed
the
add-state-directory
branch
from
4f810d4 to
f5360c4
Compare
|
I was able to test this locally well - I changed the default for FSAC to my user folder, opened a scratch workspace (which previously had contained a |
…like the symbol cache. defaults to the current working directory
…der and writer are pointing at the same thing
baronfel
force-pushed
the
add-state-directory
branch
from
f5360c4 to
8370906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of #912: it adds the option to specify where workspace-local state should be stored.
This value is defaulted to the current directory (which preserves the current behavior). The idea would be for a client host like Ionide to get a workspace-local value from the host IDE (in the VSCode context this comes from the extension's context during activation), and then flow that value down to FSAC.
The net user-facing benefit here would be to get the
.ionidedirectory out of user view, since it doesn't contain anything that a user can actually do anything with.