Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP | Implement background-size contain and cover #89

Merged
merged 2 commits into from
Jan 9, 2019
Merged

WIP | Implement background-size contain and cover #89

merged 2 commits into from
Jan 9, 2019

Conversation

locks
Copy link
Contributor

@locks locks commented Jan 9, 2019

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 709

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 202 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
azul-css/src/css_properties.rs 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
target/debug/build/azul_glium-2fd4acd17fff9eef/out/gl_bindings.rs 202 0.0%
Totals Coverage Status
Change from base Build 707: -0.07%
Covered Lines: 0
Relevant Lines: 1420

💛 - Coveralls

@fschutt
Copy link
Owner

fschutt commented Jan 9, 2019

Yeah, I don't have anything to review, this is more or less how it should be. One could argue that it would be better to use &Option<StyleBackgroundSize>, instead of Option<StyleBackgroundSize>, but it probably doesn't matter. Thanks for taking the time to do this.

@fschutt fschutt merged commit 5072e38 into fschutt:master Jan 9, 2019
@locks locks deleted the implement-background-size branch January 9, 2019 20:42
@locks locks mentioned this pull request Jan 10, 2019
4 tasks
fschutt added a commit that referenced this pull request May 13, 2019
Implement background-size:contain and background-size:cover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants