Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRO] Add path svgicons #2459

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[SRO] Add path svgicons #2459

merged 1 commit into from
Sep 26, 2024

Conversation

tiffanynwyeung
Copy link
Collaborator

@tiffanynwyeung tiffanynwyeung commented Sep 24, 2024

Describe your changes

  • create svgicons for all paths
  • create PathIcon component

Note: not sure if we should equally change the capitalization of PathKey to make sure Pando reads it properly? @nguyentvan7

Issue or discord link

Testing/validation

Note the icons used in the titles of each light cone.
image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented Sep 24, 2024

[sr-frontend] [Tue Sep 24 09:44:14 UTC 2024] - Deployed 6e682ec to https://genshin-optimizer-prs.github.io/pr/2459/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Wed Sep 25 10:02:13 UTC 2024] - Deployed 6e682ec to https://genshin-optimizer-prs.github.io/pr/2459/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Thu Sep 26 19:55:39 UTC 2024] - Deleted deployment

@tiffanynwyeung tiffanynwyeung added the SRO For Star Rail Optimizer label Sep 25, 2024
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiffanynwyeung tiffanynwyeung merged commit 6ed653c into master Sep 26, 2024
9 checks passed
@tiffanynwyeung tiffanynwyeung deleted the sro/add-path-icons branch September 26, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SRO For Star Rail Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants