Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert AST nodes to struct & remove suffix from public data members #45

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

Lai-YT
Copy link
Collaborator

@Lai-YT Lai-YT commented Oct 4, 2023

As discussed in issue #43, all AST nodes are meant to be pure data structures.
Additionally, in response to issue #39, suffixes have been removed.

@Lai-YT Lai-YT requested a review from leewei05 October 4, 2023 16:04
@Lai-YT Lai-YT self-assigned this Oct 4, 2023
Copy link
Contributor

@leewei05 leewei05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@leewei05 leewei05 merged commit d1bb58d into fruits-lab:main Oct 5, 2023
2 checks passed
@Lai-YT Lai-YT deleted the convert-ast-nodes-to-struct branch December 2, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants