Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate implementation from headers #31

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

Lai-YT
Copy link
Collaborator

@Lai-YT Lai-YT commented Sep 10, 2023

This PR separates the implementation from headers, enabling incremental builds and promoting the decoupling of objects. Dependencies between files are now automatically managed using the MMD flag, and implementation files (e.g., *.c, *.cpp) are compiled utilizing implicit rules.

Regarding the project layout, I propose that we adopt The Pitchfork Layout (PFL) as a recommended structure.

Please note that I haven't delved into the details of PFL yet 😶‍🌫️. However, we can refer to it whenever we have questions or need guidance regarding the project's layout.

@Lai-YT Lai-YT requested a review from leewei05 September 10, 2023 10:59
@Lai-YT Lai-YT self-assigned this Sep 10, 2023
@Lai-YT Lai-YT force-pushed the separate-header-and-impl branch 2 times, most recently from 5ac148f to c0e7343 Compare September 11, 2023 01:15
Copy link
Contributor

@leewei05 leewei05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@leewei05 leewei05 merged commit c88c9cd into fruits-lab:main Sep 11, 2023
@Lai-YT Lai-YT deleted the separate-header-and-impl branch September 15, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants