-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse record declaration while declaring variable #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
leewei05
force-pushed
the
record-designators
branch
from
October 18, 2024 17:42
9a8936d
to
6c607ed
Compare
Lai-YT
requested changes
Oct 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COOL 😎
leewei05
force-pushed
the
record-designators
branch
from
October 19, 2024 05:07
6c607ed
to
7296776
Compare
Added code generation tests since this doesn't require additional code generation implementations. |
Lai-YT
requested changes
Oct 19, 2024
leewei05
force-pushed
the
record-designators
branch
from
October 19, 2024 05:44
68b2513
to
e743bea
Compare
Lai-YT
approved these changes
Oct 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current parser only support type declaration and variable declaration separately. With this update, users can declare both custom type and variable at the same type. Example,
Noting that I added a set for tracking custom types, so that the compiler doesn't dump type declaration every time a custom type is used.