-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse struct and union #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leewei05
force-pushed
the
parse-struct-union
branch
2 times, most recently
from
May 10, 2024 07:18
04ee10a
to
cf6a88c
Compare
leewei05
force-pushed
the
parse-struct-union
branch
from
May 10, 2024 13:58
cf6a88c
to
3120a7b
Compare
leewei05
force-pushed
the
parse-struct-union
branch
from
May 10, 2024 14:02
3120a7b
to
fd4fdb2
Compare
Lai-YT
requested changes
May 13, 2024
Lai-YT
requested changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks good to me. 🥳
leewei05
force-pushed
the
parse-struct-union
branch
from
May 13, 2024 12:18
7d06d8a
to
60b6f43
Compare
Lai-YT
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Looking forward to the support of struct and union! 🚀
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parses struct and union type declaration.
RecordDeclNode
for struct and union.FieldNode
for fields of struct or union.StructType
andUnionType
.TODO: Just like we discusses, I will create a new symbol table (probably the same members but different name) under scope in the future PRs.
The output format is copied from clang:
Related to: #140