Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add widget name to render #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arturodelreal
Copy link

assign the new FroalaEditor to a constant in the javascript render.

@StevenMapes
Copy link

Can I suggest that this PR is changed so that the JS var is set by using the el_id and not a settings.py variable as if you have more than one instance on a page this will break as the code will try to define the constant multiple times. Though is it even needed as you can reload the instance by using let froala_editor_1 = FroalaEditor('#id_of_the_input_element');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants