limit show elements in list and highlight of user mentioned #91
Conversation
|
@piscitelli91 hey, thanks for you PR, great features, will try to merge ASAP |
| members: { | ||
| type: Array, | ||
| default: () => [] | ||
| }, |
There was a problem hiding this comment.
@piscitelli91 I'm confused why the prop of members is deleted 😕 it will break the members passing in
There was a problem hiding this comment.
You are right, i knought that the pull request send my branch at the date of pull request and not for future commits (I'm working on new functions that I will discuss with you).
I will create a new branch until this commit: 9196ffe
Sorry for mistake :)
There was a problem hiding this comment.
@piscitelli91 that would be cool, otherwise, I'm also trying to merge with fix if possible
| } | ||
| }, | ||
| computed: { | ||
| atItems () { | ||
| return this.at ? [this.at] : this.ats | ||
| return this.ats.map(at => at.symbol) |
There was a problem hiding this comment.
Obviously, change like this is something breaking, against all the versions before this, and will influenced all the users who use this library.
|
Hey, is the highlighting feature added for mentioned user? |
This commit adds two new properties: maxLoadUsers and enableHighlight.
With the property maxLoadUser the component limits a number of elements to show. MaxLoadUser is an integer property, and when it sets at -1, it shows all elements.
With the property enableHighlight, a function adds to a div with contenteditable=true a span with class=mentioned and with text the value.