Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database semantic conventions #8

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Update database semantic conventions #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ The following of the Span's attributes map to special fields in Application Insi
| `db.statement` | Dependency Data |
| `http.host` | Dependency Target |
| `net.peer.name` | Dependency Target |
| `db.instance` | Dependency Target |
| `db.name` | Dependency Target |
| `http.status_code` | Dependency Result code |
| `db.type` | Dependency Type |
| `db.system` | Dependency Type |
| `messaging.system` | Dependency Type |
| `"HTTP"` if any `http.` attribute exists | Dependency Type |
| `"DB"` if any `db.` attribute exists | Dependency Type |
Expand Down
16 changes: 8 additions & 8 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@
//! | `db.statement` | Dependency Data |
//! | `http.host` | Dependency Target |
//! | `net.peer.name` | Dependency Target |
//! | `db.instance` | Dependency Target |
//! | `db.name` | Dependency Target |
//! | `http.status_code` | Dependency Result code |
//! | `db.type` | Dependency Type |
//! | `db.system` | Dependency Type |
//! | `messaging.system` | Dependency Type |
//! | `"HTTP"` if any `http.` attribute exists | Dependency Type |
//! | `"DB"` if any `db.` attribute exists | Dependency Type |
Expand Down Expand Up @@ -116,8 +116,8 @@ impl Exporter {
"db.statement",
"http.host",
"net.peer.name",
"db.instance",
"db.type",
"db.name",
"db.system",
"messaging.system",
]
.iter()
Expand Down Expand Up @@ -254,14 +254,14 @@ impl Exporter {
data.target = Some(String::from(*host));
} else if let Some(peer_name) = attrs.get("net.peer.name") {
data.target = Some(String::from(*peer_name));
} else if let Some(db_instance) = attrs.get("db.instance") {
data.target = Some(String::from(*db_instance));
} else if let Some(db_name) = attrs.get("db.name") {
data.target = Some(String::from(*db_name));
}
if span.span_kind == SpanKind::Internal {
data.type_ = Some("InProc".into());
data.success = Some(true);
} else if let Some(db_type) = attrs.get("db.type") {
data.type_ = Some(String::from(*db_type));
} else if let Some(db_system) = attrs.get("db.system") {
data.type_ = Some(String::from(*db_system));
} else if let Some(messaging_system) = attrs.get("messaging.system") {
data.type_ = Some(String::from(*messaging_system));
} else if attrs.keys().any(|x| x.starts_with("http.")) {
Expand Down