Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Connection (and custom Connector) #30

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

clue
Copy link
Contributor

@clue clue commented Feb 5, 2018

This simple PR adds documentation for the Connection class and how an explicit instance of ConnectorInterface can be passed to it. This also removes the hard-coded default DNS server and makes sure this will be applied automatically once reactphp/socket#90 is in (which I'm currently working on).

Builds on top of #24

@bixuehujin bixuehujin merged commit 80527df into friends-of-reactphp:master Feb 6, 2018
@clue clue deleted the docs-connector branch February 25, 2018 14:16
@clue clue added this to the v0.3.0 milestone Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants