Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset fixes parsing an
ERR
response after a result set. Previously, this would trigger a parser error that would corrupt the entire connection ("Not enough data in buffer").This error situation is a bit harder to reproduce. For example, this can be triggered in a connection by invoking a
KILL QUERY n
query from a second connection. Errors for invalid queries (SELECT unknown
) would still trigger the existing logic.In the following diagram, we already supported the transition from
COM_QUERY_RESPONSE
toERR
just fine. We now also support the transition fromROW
/EOF
toERR
:From https://dev.mysql.com/doc/internals/en/com-query-response.html#text-resultset
Together with the analysis in ticket #123, you're looking at ~8 hours of work, enjoy!
Refs #123