Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ajax frontcontroller #6

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

LouisAUTHIE
Copy link

@LouisAUTHIE LouisAUTHIE commented Oct 20, 2023

Fixes issue #4

@micka-fdz
Copy link

micka-fdz commented Oct 20, 2023

Hi @LouisAUTHIE, friendly remind to not forget index.php files in new folders.

@LouisAUTHIE
Copy link
Author

Will do indeed thanks and the redirection on Ajax.php too

@micka-fdz
Copy link

Thanks @LouisAUTHIE 👍

@LouisAUTHIE
Copy link
Author

Should be good now

@micka-fdz
Copy link

micka-fdz commented Oct 24, 2023

@LouisAUTHIE could you add "Fixes #4." on PR description please?
This will automatically close the issue when the PR is merged.

@LouisAUTHIE
Copy link
Author

That's all done thanks

Copy link

@webrdinfo webrdinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK Pour moi

@micka-fdz
Copy link

@LouisAUTHIE you need to write exactly "Fixes #4" on PR description.

See documentation: Using keywords in issues and pull requests

@jf-viguier
Copy link
Member

@LouisAUTHIE est-ce que tu peux rebase stp ?

@jf-viguier jf-viguier linked an issue Oct 25, 2023 that may be closed by this pull request
@micka-fdz
Copy link

@LouisAUTHIE you just need to rebase using your changes and launch php vendor/bin/php-cs-fixer fix

@LouisAUTHIE
Copy link
Author

Yes will do as soon as I have my computer at disposal... canary island trip before !

@LouisAUTHIE
Copy link
Author

rebase is done now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Ajax.php to front controller
4 participants