Bugfix/tests #72

Kick1911 · 2020-11-16T10:48:48Z

Fixing tests to run on python 3.7

All tests pass on tox (besides the ones that are skipped)
1 test fails on pytest --use-docker tests/ (tests/apps/test_measure.py::test_with_orig[CSVStore])

Main changes

Tag for docker image safarov/freeswitch must now be specified. Using 1.10.3

goodboy · 2020-11-16T14:23:53Z

@Kick1911 oh wow thanks for doing this 🥳

I'm going to take an in depth look this afternoon EST.

Talk soon 🏄

goodboy · 2020-11-16T15:16:57Z

@Kick1911 one thing that could happen right now is re-enabling the CI run in travis, though likely flipping to GH actions would be more desirable for a load heavy test set like this.

I think we disabled it as part of #65.

goodboy · 2020-11-16T16:20:18Z

tests/test_connection.py

@@ -33,7 +33,7 @@ def con(fshost, loop):
 @pytest.mark.parametrize(
    'password, expect_auth',
    [('doggy', False), ('ClueCon', True)],
-    ids=lambda item: "pw={}, expect_auth={}".format(*item),
+    # ids=lambda item: "pw={}, expect_auth={}".format(*item),


Is there a reason this was removed?

It's not a big deal but iirc these ids tags sure are handy when doing manual runs of the test suite from console.

I have added it back in, but it works differently now.

goodboy

@sudonum yeah this looks great to me 👍

The only thing I'd love to see in this PR is tweaks to get CI working again.
Let me see if I can figure that out this afternoon.

goodboy · 2020-11-16T16:27:19Z

Huh, so can't remember if I disabled the CI run or not but the results from this branch are here:
https://travis-ci.org/github/friends-of-freeswitch/switchio

Looks like for nightly we need to install a newer C++ compiler.
I'm tempted to just move everything to GH actions since it's been far superior in a lot of ways and it's more juice for parallel builds.

goodboy · 2020-11-16T16:40:15Z

There, travis needed to be re-synced 🙄

Kick1911 · 2020-11-16T23:49:03Z

I am busy trying to get GH action to work on my fork. I am getting somewhere.

goodboy · 2020-11-17T02:21:25Z

@Kick1911 just looking at your actions run and it looks like we might be still hitting the same issue of needing a health check directive in the dockerfile as required by the pytest-dockerctl plugin.

I think this may be why the CI stopped working initially as well?
I don't recall requiring it initially and maybe it was changes to docker-py/docker that allowed this to work before?

Maybe we can just stick in a flag to ignore the health check in the plugin or see if this freeswitch image can be changed to include it?

goodboy · 2020-11-17T02:28:44Z

Huh, the health check appears to be in the base image so i'm not entirely sure what's wrong here. It also is in the official image. Maybe it's this attr path is incorrect?

goodboy · 2021-04-08T13:36:00Z

@Kick1911 if you're confident in this I'm fine to merge.

This project needs some life brought back 😂

Kick1911 · 2021-04-08T15:02:25Z

@Kick1911 if you're confident in this I'm fine to merge.

This project needs some life brought back

@goodboy I am not completely happy with it yet. In my experimentation branch I realised that some changes I made are not backwards compatible. I realised this when manually running the tests on my laptop with different versions on python 3.x.
So, I would really like the testing to work so we could not make mistakes like that. I think I will give it another try, this time making a docker on my laptop that runs docker and runs the tests. (I was using VMs to run the tests)
Logic is if I can recreate the error on my laptop, it will be much easier to debug.

I made it backwards compatible here:
d6b56c1

goodboy · 2021-04-09T15:38:26Z

I realised that some changes I made are not backwards compatible. I realised this when manually running the tests on my laptop with different versions on python 3.x.
So, I would really like the testing to work so we could not make mistakes like that. I think I will give it another try, this time making a docker on my laptop that runs docker and runs the tests.

@Kick1911 sounds good. Just let me know when you're happy.

I'm pretty sure running the tests locally should be pretty straight forward.
As mentioned I'm pretty sure the latest issue in CI is just some silly health check thing.

Kick1911 · 2021-04-24T23:31:53Z

Ok. Found out what the problem was by pure luck.
Added the fix for the testing problem and backwards compatibility for < python 3.7.
You can check how the tests run on our fork PR number 2.
https://github.com/sudonum/switchio/pull/2/checks

All tests pass for python 3.6. One test fails for python 3.7 and 3.8.
They fail on tests/apps/test_measure.py::test_with_orig[CSVStore] FAILED with a TimeoutError.
I don't know what that is about. Maybe you @goodboy can guide me on that.

Kick1911 · 2021-04-28T15:01:34Z

@goodboy I think you can merge it now and enable the github action that I have added if you are happy. Unless you want to see all tests passing, then I can change it to only run tests for python 3.6 to get the nice green tick.

goodboy · 2021-04-30T16:15:23Z

hey @Kick1911 thanks for this work and sorry about 👻 ing again - I'm not paying attention to the GH feed as much as I should.

You can check how the tests run on our fork PR number 2.

Amazing. nice to see the suite run on 3.8 as well.
I'm noticing that 3.6 and 3.7 runs hung and were cancelled?
Any idea what's going on there?

then I can change it to only run tests for python 3.6 to get the nice green tick.

Weird i only see the 3.8 run actually terminating with the one error.

They fail on tests/apps/test_measure.py::test_with_orig[CSVStore] FAILED with a TimeoutError.

Can we maybe just skip this test for now and make an issue about it?

Thanks again for all this hard work!

goodboy · 2021-04-30T16:22:41Z

tests/conftest.py

@@ -67,7 +67,7 @@ def containers(request, confdir):
    if request.config.option.usedocker:
        docker = request.getfixturevalue('dockerctl')
        with docker.run(
-            'safarov/freeswitch',
+            'safarov/freeswitch:1.10.3',


We should probably have a CD process eventually that keeps us in sync with core fs.

Looks like the maintainer added a latest tag 4 months ago. I'll use that tag instead.

goodboy · 2021-04-30T16:25:31Z

Hmm also, aren't we going to need a version pin in setup.py for 3.6?

Gonna be nice to get a new release out if we can get this all up and running again 🏄🏼

Kick1911 · 2021-05-01T23:58:14Z

@goodboy Ok, I think it is all good now. All tests pass.
https://github.com/sudonum/switchio/runs/2484324517?check_suite_focus=true

goodboy · 2021-05-02T16:53:04Z

tests/conftest.py

@@ -67,7 +67,7 @@ def containers(request, confdir):
    if request.config.option.usedocker:
        docker = request.getfixturevalue('dockerctl')
        with docker.run(
-            'safarov/freeswitch:1.10.3',
+            'safarov/freeswitch:latest',


goodboy · 2021-05-02T16:57:07Z

tests/apps/test_measure.py

@@ -271,6 +271,11 @@ def test_with_orig(get_orig, measure, storer):

    # configure max calls originated to length of of storer buffer
    cdr_storer = orig.measurers['CDR'].storer
+
+    if (cdr_storer.storetype.__name__ == 'CSVStore'


Not sure what's up here but we're skipping this measurement test for now since it's flaky in github actions.

This was to skip that storertype, but not skip the other storertype. I didn't know if I should skip the test completely for all python 3.7+ or not.

goodboy · 2021-05-02T16:59:12Z

Created #74 to track otherwise I think this is ready to land.

@Kick1911 only last thing might be to change readme to say we're 3.6+ now yah?

Kick1911 · 2021-05-02T17:12:10Z

Created #74 to track otherwise I think this is ready to land.

@Kick1911 only last thing might be to change readme to say we're 3.6+ now yah?

Sure. Will do.

Kick1911 · 2021-05-02T17:30:15Z

@goodboy Done

goodboy · 2021-05-02T18:08:40Z

@Kick1911 oh shoot we probably need to move the CI readme badge to GH actions as well.

Feel free to PR that in if you want but no presh.

goodboy · 2021-05-02T18:09:14Z

master run : https://github.com/friends-of-freeswitch/switchio/actions/runs/804780948

Kick1911 added 3 commits November 16, 2020 12:32

Fix deprecated warnings

5f3be96

Fix deprecated use of packages

c9eee23

Fixes to get tests running

a13619d

goodboy requested review from moises-silva and vodik November 16, 2020 15:17

goodboy reviewed Nov 16, 2020

View reviewed changes

goodboy approved these changes Nov 16, 2020

View reviewed changes

Add numpy to requirements and fix pytest ids

dc5c835

moises-silva approved these changes Apr 9, 2021

View reviewed changes

Kick1911 added 2 commits April 25, 2021 01:18

Backwards compatibility for < python-3.7

df36aae

Fix CI tests and add github actions

00e7e15

goodboy reviewed Apr 30, 2021

View reviewed changes

Kick1911 added 2 commits May 1, 2021 01:50

Skip failing test. Use latest freeswitch tag. Pin python

0d25921

Use absolute paths

37b9271

goodboy reviewed May 2, 2021

View reviewed changes

goodboy mentioned this pull request May 2, 2021

Hanging CDR test in CI #74

Open

Bump the python version requirement in README

3ee4a3f

goodboy merged commit 0e7aa9f into friends-of-freeswitch:master May 2, 2021

goodboy mentioned this pull request May 4, 2021

First minor release? #76

Open

5 tasks

goodboy mentioned this pull request May 31, 2021

CI is borked (shocker) #65

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix/tests #72

Bugfix/tests #72

Kick1911 commented Nov 16, 2020

goodboy commented Nov 16, 2020

goodboy commented Nov 16, 2020

goodboy Nov 16, 2020

Kick1911 Nov 16, 2020

goodboy left a comment

goodboy commented Nov 16, 2020

goodboy commented Nov 16, 2020

Kick1911 commented Nov 16, 2020 •

edited

Loading

goodboy commented Nov 17, 2020

goodboy commented Nov 17, 2020 •

edited

Loading

goodboy commented Apr 8, 2021

Kick1911 commented Apr 8, 2021 •

edited

Loading

goodboy commented Apr 9, 2021 •

edited

Loading

Kick1911 commented Apr 24, 2021 •

edited

Loading

Kick1911 commented Apr 28, 2021

goodboy commented Apr 30, 2021 •

edited

Loading

goodboy Apr 30, 2021

Kick1911 Apr 30, 2021

goodboy commented Apr 30, 2021

Kick1911 commented May 1, 2021

goodboy May 2, 2021

goodboy May 2, 2021

Kick1911 May 2, 2021

goodboy commented May 2, 2021

Kick1911 commented May 2, 2021

Kick1911 commented May 2, 2021

goodboy commented May 2, 2021

goodboy commented May 2, 2021

Bugfix/tests #72

Bugfix/tests #72

Conversation

Kick1911 commented Nov 16, 2020

Main changes

goodboy commented Nov 16, 2020

goodboy commented Nov 16, 2020

goodboy Nov 16, 2020

Choose a reason for hiding this comment

Kick1911 Nov 16, 2020

Choose a reason for hiding this comment

goodboy left a comment

Choose a reason for hiding this comment

goodboy commented Nov 16, 2020

goodboy commented Nov 16, 2020

Kick1911 commented Nov 16, 2020 • edited Loading

goodboy commented Nov 17, 2020

goodboy commented Nov 17, 2020 • edited Loading

goodboy commented Apr 8, 2021

Kick1911 commented Apr 8, 2021 • edited Loading

goodboy commented Apr 9, 2021 • edited Loading

Kick1911 commented Apr 24, 2021 • edited Loading

Kick1911 commented Apr 28, 2021

goodboy commented Apr 30, 2021 • edited Loading

goodboy Apr 30, 2021

Choose a reason for hiding this comment

Kick1911 Apr 30, 2021

Choose a reason for hiding this comment

goodboy commented Apr 30, 2021

Kick1911 commented May 1, 2021

goodboy May 2, 2021

Choose a reason for hiding this comment

goodboy May 2, 2021

Choose a reason for hiding this comment

Kick1911 May 2, 2021

Choose a reason for hiding this comment

goodboy commented May 2, 2021

Kick1911 commented May 2, 2021

Kick1911 commented May 2, 2021

goodboy commented May 2, 2021

goodboy commented May 2, 2021

Kick1911 commented Nov 16, 2020 •

edited

Loading

goodboy commented Nov 17, 2020 •

edited

Loading

Kick1911 commented Apr 8, 2021 •

edited

Loading

goodboy commented Apr 9, 2021 •

edited

Loading

Kick1911 commented Apr 24, 2021 •

edited

Loading

goodboy commented Apr 30, 2021 •

edited

Loading