core: Add specific signals type hinting #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oriori1703
reviewed
Oct 29, 2022
yotamN
force-pushed
the
feature/signal_type_hinting
branch
from
668b9e3 to
6d04fad
Compare
yotamN
force-pushed
the
feature/signal_type_hinting
branch
10 times, most recently
from
3e3e111 to
698c9b3
Compare
|
Bus is the only class that I haven't add a specific handler, I don't think it's a blocker as it's already vastly better. |
yotamN
force-pushed
the
feature/signal_type_hinting
branch
from
698c9b3 to
33f1df3
Compare
oriori1703
suggested changes
Jan 14, 2023
yotamN
force-pushed
the
feature/signal_type_hinting
branch
from
33f1df3 to
b945967
Compare
PEP 517 specify a new format for build systems and PEP 518 specify how we should require packages for our build system. Setuptools support PEP 517 so we should use it that way.
yotamN
force-pushed
the
feature/signal_type_hinting
branch
from
b945967 to
ddcfbcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes with message listeners are: