Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate specs to the new content management system #413

Closed
28 of 34 tasks
rufuspollock opened this issue Jan 27, 2020 · 5 comments
Closed
28 of 34 tasks

Migrate specs to the new content management system #413

rufuspollock opened this issue Jan 27, 2020 · 5 comments
Assignees

Comments

@rufuspollock
Copy link
Contributor

rufuspollock commented Jan 27, 2020

We want to migrate the /specs/ section covering the Frictionless Specs and esp data package are migrated over.

  • Specs live in their own repo and should stay there
  • Want to have them show up in the main site
  • Schemas need to show up somewhere ...

Acceptance

Tasks

Sort out the build

Misc

  • Set the CNAME
  • DNS update - currently specs.frictionlessdata.io redirects to frictionlessdata.io/specs
  • Add permanent redirects (301 HTTP status) in fd.io to new locations ... - should be part of [v2] Implement Redirects for v1 URLs #423 turns out you can't do this in Vue 1 so we have to implement this at cloudflare level
    • /specs/* => specs.fd.io/*
    • /schemas/* => specs.fd.io/schemas/

Later

  • Examine schemas build process - can we simplify this ...

Inbox

  • (?) Move contributing stuff out of README to contributing

Refactoring each spec to vuepress markdown

  • Pay attention to full frictionlessdata.io URLs. Change them to relative URLs.
    [Data Package specification](http://frictionlessdata.io/specs/data-package/)
    
    should become
    
    [Data Package specification](/data-package/)
    
  • Document, using Markdown's frontmatter, when a spec is under development. The ones under development are documented in the spreadsheet.
    https://docs.google.com/spreadsheets/d/1qByu4qw56hFUdJIY5IOC7d8TQBud-k31J6720hg1h2w/edit#gid=1449054173
  • Double check for broken links.
  • Use a spell checker before commiting.

Analysis

Misc

Do we go with specs.fd.io or fd.io/specs

  • fd.io/specs sets up an annoying coupling ... 🐛
    • specs repo has to worry about templating and set up on fd.io
    • fd.io has to submodule in specs at build time
    • 🐛 fd.io does not (currently) rebuild on changes to specs (and would be painful to do)
    • 🐛 specs have weird lektor like layout in markdown and have to have a build script simply to convert md to lr name. For a specs contributor this is weird.
  • Painful to modify specs e.g. to have versions (latest vs v1)
  • 🐛 we have core schemas living on a perma-url on frictionlessdata.io ... at /schemas/ this is core product functionality on a "presentation" website
  • (Separate) We have some complex build structure to build the json schemas ...
  • 🐛 building json schemas may prevent the website from deploying

KISS suggests subsite is simpler ...

  • SEO is fine
  • We can share branding
  • Very clean specs site and build
  • Easy to revert from if needed

Current flow for deploying specs to the website:

Current build process (via Grunt.js task in website)

  • submodule in the repo
  • build it
  • copy directories around

Details

  1. website project runs grunt specs. https://github.com/frictionlessdata/website/blob/master/Gruntfile.js#L87-L100
  2. grunt specs clones specs repository and runs npm build and npm test
  3. specs npm run build runs build.js with node. https://github.com/frictionlessdata/specs/blob/master/build.js#L108-L110

https://github.com/frictionlessdata/website/blob/master/Gruntfile.js#L87-L100

Footnotes

  1. vue router can only do internal redirects.

@monikappv monikappv self-assigned this Jan 27, 2020
@Irio Irio mentioned this issue Jan 28, 2020
14 tasks
rufuspollock added a commit to frictionlessdata/datapackage that referenced this issue Feb 9, 2020
@rufuspollock
Copy link
Contributor Author

@monikappv please can you take this on - or, at least the tasks I've specifically marked for you.

I've made a start already on this here in a new branch back-to-own-subsite-2020:

https://github.com/frictionlessdata/specs/tree/back-to-own-subsite-2020

In particular, i've already migrated one spec back to give you an example (see the last commit in that branch).

To start: just clone, switch to that branch, npm install, boot the server and start doing the work. You can then keep pushing to that branch. Once we are complete we can merge back into master - but not before then.

rufuspollock added a commit to frictionlessdata/datapackage that referenced this issue Feb 16, 2020
…t - refs frictionlessdata/frictionlessdata.io#413.

* Remove specs tests as kind of pointless now
* Remove specs build from build.js as vuepress now does that!
@rufuspollock
Copy link
Contributor Author

@monikappv can you update with a screenshot of what this now looks like.

rufuspollock added a commit to frictionlessdata/datapackage that referenced this issue Feb 16, 2020
rufuspollock added a commit to frictionlessdata/datapackage that referenced this issue Feb 16, 2020
…sdata/frictionlessdata.io#413.

* remove changelog.md as no content
* home: remove travis build plus add a link
* move up security_matrix.png
@monikappv
Copy link
Member

@rufuspollock here is a screenshot of Specs home page and one specs page (CSV dialect)

FDspecsHome

FDspecsExample

@nirabpudasaini
Copy link

nirabpudasaini commented Feb 25, 2020

Frontmatter Alignment for Specs:

  • Remove slug from all frontmatter
  • Change Full URL to relative URL
  • Document specs metadata and use them to align frontmatter
  • Link to schema from Metatable component
  • Mark the specs that are under development in frontmatter
  • Check for broken links
  • Check for spelling errors using a spellchecker

@rufuspollock
Copy link
Contributor Author

FIXED. All done that needs to be done. Remaining redirects is in #432 and minor extras can be done later if at all. https://specs.frictionlessdata.io/

lauragift21 pushed a commit to frictionlessdata/datapackage that referenced this issue May 5, 2020
lauragift21 pushed a commit to frictionlessdata/datapackage that referenced this issue May 5, 2020
…t - refs frictionlessdata/frictionlessdata.io#413.

* Remove specs tests as kind of pointless now
* Remove specs build from build.js as vuepress now does that!
lauragift21 pushed a commit to frictionlessdata/datapackage that referenced this issue May 5, 2020
lauragift21 pushed a commit to frictionlessdata/datapackage that referenced this issue May 5, 2020
…sdata/frictionlessdata.io#413.

* remove changelog.md as no content
* home: remove travis build plus add a link
* move up security_matrix.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants