Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly read user and repo for github portal for github portal #1692

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: properly read user and repo for github portal for github portal #1692

wants to merge 1 commit into from

Conversation

pierrecamilleri
Copy link
Collaborator

@pierrecamilleri pierrecamilleri commented Oct 11, 2024 •
edited
Loading

It looks like reading user (or organization) and repository names from the URL are faulty.

I performed the manual test :

fricitonless validate https://github.com/DCMLab/dcml_corpora/releases/download/v2.1/dcml_corpora.datapackage.json

that seems to work.

Additionnal thoughts : 

  • In this fix, we currently systematically overwrite "contol.user" and "control.repo" properties. It would maybe be wise to only set these properties if they are not already set, even if I do not see a use case for this right now.
  • It would be great if I'd find a way to test this without testing internals. Maybe a way to mock Github client (platform.github.Github) ?

@pierrecamilleri pierrecamilleri changed the title fix: Properly read user and repo for github portal for github portal fix: properly read user and repo for github portal for github portal Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot access URLs
1 participant
@pierrecamilleri