Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freedesktop: use ashpd for both sync & async implementations #42

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Freedesktop: use ashpd for both sync & async implementations #42

merged 4 commits into from
Oct 8, 2024

Commits on Oct 8, 2024

  1. remove unused code

    @Be-ing
    Be-ing committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    79e58f1 View commit details
    Browse the repository at this point in the history

  2. mark doctest no-exec 

    setting up the XDG Desktop Portal on CI is not easy
    @Be-ing
    Be-ing committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    d7f5789 View commit details
    Browse the repository at this point in the history

  3. Freedesktop: use ashpd for both sync & async implementations 

    Before, the sync and async APIs had completely separate
implementations. When Linux support was first added in
frewsxcv#6
the XDG Desktop Portal color-scheme API was new and not
yet widely supported, so fallbacks were needed. Now,
the portal API is more widely supported so the fallbacks
are not needed. In my testing, the portal works on:

KDE Plasma
GNOME
Cinnamon
Xfce

MATE does not currently support the portal API. Selecting
MATE's GTK themes from Xfce's settings also does not
change what xdg-desktop-portal-gtk reports. I am not sure,
but I think that may be due to missing metadata in MATE's
GTK themes. The old implementation never worked on MATE
anyway because MATE's dark themes don't have "dark" in
their name, so there's no regression removing it.
    @Be-ing
    Be-ing committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    57974f4 View commit details
    Browse the repository at this point in the history

  4. Freedesktop: prepend initial value to async stream 

    This allows downstream applications to respond to the system
light/dark mode preference on application startup while continuing
to react to changes of the preference.
    @Be-ing
    Be-ing committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0c38918 View commit details
    Browse the repository at this point in the history