Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #41

Closed
wants to merge 4 commits into from
Closed

Conversation

bbb651
Copy link
Contributor

@bbb651 bbb651 commented Oct 6, 2024

Among other things this helps with reducing duplicated zbus dependencies, e.g. with rust-notify and recent ashpd versions.

It's not necessary and very easily conflicts
This further helps reduces instances of duplicated `zbus`.
We don't use any features past `4.0` and `zbus` say they
[don't break semver](https://github.com/dbus2/zbus/blob/6ca0f8ccef2d97ef76b4f3fd3045ec831507520e/zvariant_utils/README.md?plain=1#L9).
This is what `notify-rust` does for instance.
Weirdly `ashpd` seems to require `4.0`, but in my `Cargo.lock`
the version selected is `4.4.0`?..
Either way I don't think it can make it more restrictive.
This required no changes.
This does not affect users of the crate.
@Be-ing
Copy link
Collaborator

Be-ing commented Oct 7, 2024

obsoleted by #42 which removes most Linux-specific direct dependencies

@bbb651
Copy link
Contributor Author

bbb651 commented Oct 7, 2024

That PR doesn't resolve the overly specific futures version (and doesn't upgrade tokio but that doesn't really matter).

@Be-ing
Copy link
Collaborator

Be-ing commented Oct 8, 2024

What's the issue specifying the patch version for futures?

@bbb651
Copy link
Contributor Author

bbb651 commented Oct 8, 2024

We're not using anything past futures 0.3, and it causes it to be included multiple times in some scenarios.
It a very core crate to the ecosystem, so it's unlikely they'll break semver (it's depended on like this in a lot of crates, e.g. yew, iced, servo).

@bbb651
Copy link
Contributor Author

bbb651 commented Oct 20, 2024

Closed in favor of #48

@bbb651 bbb651 closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants