Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redundant text sent #1

Closed
CarterLi opened this issue Feb 2, 2020 · 2 comments
Closed

redundant text sent #1

CarterLi opened this issue Feb 2, 2020 · 2 comments

Comments

@CarterLi
Copy link
Contributor

CarterLi commented Feb 2, 2020

$ telnet 127.0.0.1 12345                                                                                       13:58:11
Trying 127.0.0.1...
Connected to 127.0.0.1.
Escape character is '^]'.
1234567890
1234567890
12345
12345
890

expected:

$ telnet 127.0.0.1 12345                                                                                       13:59:12
Trying 127.0.0.1...
Connected to 127.0.0.1.
Escape character is '^]'.
1234567890
1234567890
12345
12345
@frevib
Copy link
Owner

frevib commented Feb 2, 2020

Thank for submitting the issue.

This is because a fixed buffer size is used for receiving/sending the message. This project was optimized for performance testing throughput, so just it will just receive and send up to MAX_MESSAGE_LEN bytes. I'll have a look to improve it, while not adding too much CPU cycles.

@CarterLi
Copy link
Contributor Author

CarterLi commented Feb 2, 2020

This is because a fixed buffer size is used for receiving/sending the message.

Yeah I knew it

This project was optimized for performance testing throughput

But firstly the program should be correct

CarterLi added a commit to CarterLi/io_uring-echo-server that referenced this issue Feb 6, 2020
CarterLi added a commit to CarterLi/io_uring-echo-server that referenced this issue Feb 6, 2020
@frevib frevib closed this as completed in d2ec7e6 Feb 7, 2020
frevib pushed a commit that referenced this issue Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants