Add optional build flavor configuration #55
Conversation
clementd-fretlink
changed the title
There was a problem hiding this comment.
Very nice, the PR is easy to read 👌.
The only missing part is to add the new bash script in the list of necessary scripts for setuping the role: (in here:
ansible-clever/tasks/setup.yml
Lines 29 to 32 in 78c6d04
files/clever-set-build-flavor.sh to the list)
|
ah thanks for catching that |
clementd-fretlink
force-pushed
the
build-flavor
branch
from
bb8eed1 to
84cf8b1
Compare
clementd-fretlink
force-pushed
the
build-flavor
branch
from
84cf8b1 to
164e031
Compare
|
I'm starting to work again on this one, now that I know how to test changes easily |
|
Ok, I've tested it on lane-explorer, both with and without a value, it works as intended! |
clementd-fretlink
changed the title
clementd-fretlink
force-pushed
the
build-flavor
branch
from
627ddac to
f1c377e
Compare
|
I've removed the bash script and inlined the command in the task definition |
|
I have a new issue, but i don't know if it's related to my changes: https://gitlab.in.fretlink.com/fretlink/lane-explorer/-/jobs/156256#L783 |
|
After some investigation, i think the error was introduced when we went from |
clementd-fretlink
force-pushed
the
build-flavor
branch
from
ef6055a to
f1c377e
Compare
can you mention it in the |
README.md
Outdated
| @@ -35,6 +35,7 @@ Variables for the application | |||
| - _Obsolete_: `clever_metrics`: metrics used to be disabled by default. Now they are enabled by default and can be explicitly disabled with `clever_disable_metrics`. | |||
| - `clever_disable_metrics`: a boolean to disable metrics support. Optional, default to `false`. | |||
| - `clever_env_output_file`: as a post deploy task you might need to retrieve the full Clever environment configuration (i.e. with addon env variables). If this variable is set to a filename then the env will be retrieved after a successful deploy inside this file. Optional. | |||
| - `clever_build_flavor`: an optional text value used to configure the size of the dedicated build instance. `None` delegates to clever cloud default behaviour. `Some "disabled"` disables the dedicated build instance altogether. | |||
There was a problem hiding this comment.
can you add the variable in the defaults/main.yml file please? (for people not using Dhall)
There was a problem hiding this comment.
Is this needed, since its default value is to be not defined? How can I do it in yaml?
There was a problem hiding this comment.
Indeed the default value in the ansible variables is not needed. However you mention two exemple values of None and Some "disabled". I think you should remove the Some part which is specific to dhall :)
There was a problem hiding this comment.
ah, good catch. I've changed the wording to avoid using dhallisms.
clementd-fretlink
force-pushed
the
build-flavor
branch
from
d5d14ea to
8a5d45d
Compare
This requires
clever-tools v1.5.0or higher