fix(button): Patch for IE 11 helpkit-ember buttons #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibulijack-fd
suggested changes
Feb 24, 2020
| {{else}} | ||
| <span class="icon-holder"> | ||
| {{nucleus-icon name=icon size=_iconSize}} | ||
| </span> |
There was a problem hiding this comment.
Refactor this piece of code such that there's only one nucleus-icon invocation. Perhaps always have the span class icon-holder with an optional .active class based on iconOnly property.
| @@ -37,6 +37,11 @@ $active-box-shadow: inset 0 0 4px 0 rgba(0, 0, 0, .25); | |||
| height: 32px; | |||
| min-width: 80px; | |||
|
|
|||
| & .icon-holder { | |||
There was a problem hiding this comment.
Follow BEM conventions.
http://getbem.com/naming/
shibulijack-fd
suggested changes
Feb 24, 2020
| @@ -37,6 +37,11 @@ $active-box-shadow: inset 0 0 4px 0 rgba(0, 0, 0, .25); | |||
| height: 32px; | |||
| min-width: 80px; | |||
|
|
|||
| & .nucleus-button__icon.active { | |||
There was a problem hiding this comment.
.nucleus-button is redundant. Check how this can be simplified using SCSS.
| @@ -1,4 +1,8 @@ | |||
| {{#if icon}}{{nucleus-icon name=icon size=_iconSize}}{{/if}} | |||
| {{#if icon}} | |||
| <span class="nucleus-button__icon {{unless iconOnly "active"}}"> | |||
There was a problem hiding this comment.
A class named active is quite common and the consuming apps might override our styles. So can we make this class a little more nucleus specific?
shibulijack-fd
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to patch the buttons appearance wrt to icons and on IE 11.
Changes:
nucleus-button__iconthat enforces a top value to make the icon aligned with text. (Happens only for non-iconOnly buttons)