Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info:
Button variant is not directly linked to icon variant. For instance, button of variant
danger
must display icon withsecondary
variant. Hence it requires a mapping.Also, the toast-message component uses ember-cli-flash under the hood, which returns specific types such as "Info", "Warning" etc.. While we've followed similar naming conventions in our component, there exists a small problem of capitalisation. To fix this, there are 2 possible solutions:
Solution#1: Helper
Create a helper which capitalises the first letter.
Time complexity: O(n)
Space complexity: O(1)
Solution#2: JS Map
Create a simple mapper like:
Time complexity: O(1)
Space complexity: O(n)
Although the helper seemed like a straight-forward solution at first, creating a modifier function is an overkill for a small component which does not even reuse this functionality. Hence, I'm going with the faster solution.