Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): change in prop names #106

Merged
merged 1 commit into from
Feb 6, 2020
Merged

fix(button): change in prop names #106

merged 1 commit into from
Feb 6, 2020

Conversation

sharath-sriram
Copy link
Contributor

The following props in Nucleus Button have been renamed to avoid confusion with their corresponding HTML attributes:

Old Prop Name New Prop Name Function
type variant Describes the type of button - ex. primary, danger etc.
value args The arguments passed to the onClick function

@shibulijack-fd shibulijack-fd merged commit 1b08e79 into master Feb 6, 2020
@shibulijack-fd shibulijack-fd deleted the button-props branch February 6, 2020 11:01
@weekly-digest weekly-digest bot mentioned this pull request Feb 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shibulijack-fd shibulijack-fd shibulijack-fd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharath-sriram @shibulijack-fd