Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Style lint implementation #105

Merged
merged 11 commits into from
Feb 7, 2020
Merged

chore: Style lint implementation #105

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9194232
Style lint implementation
prakash-chokalingam Feb 6, 2020
13d45b6
remove style script
prakash-chokalingam Feb 6, 2020
702d4db
no lint on tests
prakash-chokalingam Feb 6, 2020
9752a8d
Removed .eslintignore & pointed to .gitignore
prakash-chokalingam Feb 7, 2020
a8bbcd7
Removed .stylintrc
prakash-chokalingam Feb 7, 2020
1b73761
Removed .template-lintrc.js
prakash-chokalingam Feb 7, 2020
3c60d6f
lint-staged fix
prakash-chokalingam Feb 7, 2020
4861384
Added lints & cleanups
prakash-chokalingam Feb 7, 2020
4c2372e
Removed scripts & depenedencies
prakash-chokalingam Feb 7, 2020
d0291bf
Merge branch 'master' into style-lint-check
shibulijack-fd Feb 7, 2020
5027f57
bare string check & ignored test dummy files
prakash-chokalingam Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"start": "yarn workspace nucleus start",
"test": "lerna run test --no-private --stream --concurrency 1",
"build": "lerna run build --parallel --no-private",
"lint": "lerna run lint:hbs --parallel && lerna run lint:js --parallel",
"lint": "lerna run lint:hbs --parallel && lerna run lint:js --parallel && lerna run lint:style --parallel",
"lint-staged": "lint-staged",
"lerna:version": "lerna version prerelease --preid beta",
"lerna:publish": "lerna publish --canary --yes --dist-tag beta",
Expand All @@ -28,7 +28,8 @@
},
"lint-staged": {
"*.js": "lerna run lint:js",
"*.hbs": "lerna run lint:hbs"
"*.hbs": "lerna run lint:hbs",
"*.scss": "lerna run lint:style"
},
"pre-commit": [
"lint-staged"
Expand Down
10 changes: 10 additions & 0 deletions packages/@nucleus/.stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "stylelint-config-standard",
"plugins": [
"stylelint-order"
],
"rules": {
"number-leading-zero": "never",
"at-rule-no-unknown": null
}
}
3 changes: 2 additions & 1 deletion packages/@nucleus/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"start": "ember serve -p 1508",
"deploy": "ember deploy production",
"test": "COVERAGE=TRUE ember test",
"test:dev": "COVERAGE=TRUE ember test --server -launch=false"
"test:dev": "COVERAGE=TRUE ember test --server -launch=false",
"lint:style": "stylelint **/*.scss"
prakash-chokalingam marked this conversation as resolved.
Show resolved Hide resolved
},
"dependencies": {
"@freshworks/banner": "^0.3.0",
Expand Down
10 changes: 10 additions & 0 deletions packages/banner/.stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
prakash-chokalingam marked this conversation as resolved.
Show resolved Hide resolved
"extends": "stylelint-config-standard",
"plugins": [
"stylelint-order"
],
"rules": {
"number-leading-zero": "never",
"at-rule-no-unknown": null
}
}
1 change: 1 addition & 0 deletions packages/banner/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"build": "ember build",
"lint:hbs": "ember-template-lint .",
"lint:js": "eslint . --fix",
"lint:style": "stylelint **/*.scss",
"start": "ember serve -p 4003",
"deploy": "ember deploy production",
"test": "ember backstop-remote & COVERAGE=TRUE ember test --test-port=1512",
Expand Down
10 changes: 10 additions & 0 deletions packages/button/.stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "stylelint-config-standard",
"plugins": [
"stylelint-order"
],
"rules": {
"number-leading-zero": "never",
"at-rule-no-unknown": null
}
}
1 change: 1 addition & 0 deletions packages/button/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"build": "ember build",
"lint:hbs": "ember-template-lint .",
"lint:js": "eslint . --fix",
"lint:style": "stylelint **/*.scss",
prakash-chokalingam marked this conversation as resolved.
Show resolved Hide resolved
"start": "ember serve -p 4003",
"deploy": "ember deploy production",
"test": "ember backstop-remote & COVERAGE=TRUE ember test --test-port=1509",
Expand Down
10 changes: 10 additions & 0 deletions packages/core/.stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "stylelint-config-standard",
"plugins": [
"stylelint-order"
],
"rules": {
"number-leading-zero": "never",
"at-rule-no-unknown": null
}
}
1 change: 1 addition & 0 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"scripts": {
"build": "ember build",
"start": "ember serve -p 4003",
"lint:style": "stylelint **/*.scss",
"deploy": "ember deploy production",
"test": "COVERAGE=TRUE ember test --test-port=1508",
"test:dev": "COVERAGE=TRUE ember test --server -launch=false"
Expand Down
10 changes: 10 additions & 0 deletions packages/icon/.stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "stylelint-config-standard",
"plugins": [
"stylelint-order"
],
"rules": {
"number-leading-zero": "never",
"at-rule-no-unknown": null
}
}
1 change: 1 addition & 0 deletions packages/icon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"build": "ember build",
"lint:hbs": "ember-template-lint .",
"lint:js": "eslint . --fix",
"lint:style": "stylelint **/*.scss",
"start": "ember serve -p 4003",
"deploy": "ember deploy production",
"test": "ember backstop-remote & COVERAGE=TRUE ember test --test-port=1514",
Expand Down
10 changes: 10 additions & 0 deletions packages/inline-banner/.stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "stylelint-config-standard",
"plugins": [
"stylelint-order"
],
"rules": {
"number-leading-zero": "never",
"at-rule-no-unknown": null
}
}
1 change: 1 addition & 0 deletions packages/inline-banner/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"build": "ember build",
"lint:hbs": "ember-template-lint .",
"lint:js": "eslint . --fix",
"lint:style": "stylelint **/*.scss",
"start": "ember serve -p 4003",
"deploy": "ember deploy production",
"test": "ember backstop-remote & COVERAGE=TRUE ember test --test-port=1513",
Expand Down
10 changes: 10 additions & 0 deletions packages/modal/.stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "stylelint-config-standard",
"plugins": [
"stylelint-order"
],
"rules": {
"number-leading-zero": "never",
"at-rule-no-unknown": null
}
}
1 change: 1 addition & 0 deletions packages/modal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"build": "ember build",
"lint:hbs": "ember-template-lint .",
"lint:js": "eslint . --fix",
"lint:style": "stylelint **/*.scss",
"start": "ember serve -p 4003",
"deploy": "ember deploy production",
"test": "ember backstop-remote & COVERAGE=TRUE ember test --test-port=1510",
Expand Down
10 changes: 10 additions & 0 deletions packages/toast-message/.stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": "stylelint-config-standard",
"plugins": [
"stylelint-order"
],
"rules": {
"number-leading-zero": "never",
"at-rule-no-unknown": null
}
}
1 change: 1 addition & 0 deletions packages/toast-message/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"build": "ember build",
"lint:hbs": "ember-template-lint .",
"lint:js": "eslint . --fix",
"lint:style": "stylelint **/*.scss",
"start": "ember serve -p 4003",
"deploy": "ember deploy production",
"test": "ember backstop-remote & COVERAGE=TRUE ember test --test-port=1511",
Expand Down