Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banner component - 'System Alerts' is not responsive #122

Closed
vigneshmanogar opened this issue Feb 19, 2020 · 0 comments · Fixed by #132
Closed

Banner component - 'System Alerts' is not responsive #122

vigneshmanogar opened this issue Feb 19, 2020 · 0 comments · Fixed by #132

Comments

@vigneshmanogar
Copy link

Description

The 'System Alerts' is not responsive in Banner component.

Versions

Ember-CLI: 3.11.0
Nucleus: 0.1.0

Current behaviour

'System Alerts' is not responsive

image

Expected behaviour

'System Alerts' should be responsive

Steps to reproduce

  1. Open Firefox browser
  2. Go to nucleus documentation site.
  3. Navigate to the 'Banner' component link under 'Components'.
  4. Press success button more than 5 times.
  5. Click on 'more button'.

Possible solution

Make the system alert take the width of viewport.
@vigneshmanogar vigneshmanogar changed the title Banner component - 'System Alerts' not responsive Banner component - 'System Alerts' is not responsive Feb 19, 2020
Vignesh-Manogar-E3433 pushed a commit that referenced this issue Feb 21, 2020
[BUGFIX #122] Fix for banner component - system alerts is not responsive
b18b708
Closed
Vignesh-Manogar-E3433 added a commit that referenced this issue Feb 21, 2020
@Vignesh-Manogar-E3433
Merge branch 'master' into bugfix/#122
3032dd1
Vignesh-Manogar-E3433 pushed a commit that referenced this issue Feb 21, 2020
fix(banner): system alerts is not responsive (#122)
b8ceffa
Merged
@weekly-digest weekly-digest bot mentioned this issue Feb 23, 2020
Closed
shibulijack-fd added a commit that referenced this issue Feb 24, 2020
@shibulijack-fd
Merge branch 'master' into bugfix/#122-banner
1fe3570
Vignesh-Manogar-E3433 added a commit that referenced this issue Feb 24, 2020
@Vignesh-Manogar-E3433
Merge pull request #132 from freshdesk/bugfix/#122-banner
7d933b2 
fix(banner): system alerts is not responsive (#122)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@vigneshmanogar