fix(Inline-banner): refactored yield (#151)

* remove htmlSafe

* removed computed property

* changed class name

* changed name in test

* changed indentations

* changed backstop setup

* changed yield content

* refactored code

* changed if/else block

packages/@nucleus/tests/dummy/app/templates/components/nucleus-inline-banner/demo-2.hbs

@@ -1,21 +1,8 @@
 {{#docs-demo as |demo|}}
   {{#demo.example name="nucleus-inline-banner-2.hbs"}}
     {{#nucleus-inline-banner type="warning" as |banner|}}
-      <div class="nucleus-inline-banner__icon">
-        {{nucleus-icon name="nucleus-circle-help" size="medium" variant="warning"}}
-      </div>
-      <div class="nucleus-inline-banner__content">
-        <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim blandit volutpat maecenas volutpat.</p>
-        <a class="docs-link" href="#">Click here</a>
-      </div>
-      <div class="nucleus-inline-banner__close">
-        {{nucleus-button
-        variant="text"
-        size="mini"
-        icon="nucleus-cross"
-        iconOnly=true
-        onClick=(action banner.close)}}
-      </div>
+      <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim blandit volutpat maecenas volutpat.</p>
+      <a class="docs-link" href="#">Click here</a>
     {{/nucleus-inline-banner}}
   {{/demo.example}}
   {{demo.snippet "nucleus-inline-banner-2.hbs"}}

packages/inline-banner/addon/templates/components/nucleus-inline-banner.hbs

@@ -1,24 +1,22 @@
-{{#if hasBlock}}
-  {{yield
-    (hash
-      close=(action "onCloseTip")
-    )
-  }}
-{{else}}
-  <div class="nucleus-inline-banner__icon">
-    {{nucleus-icon name=_icon size="medium" variant=type}}
-  </div>
-  <div class="nucleus-inline-banner__content">
-    <div data-test-id="nucleus-inline-banner-title">{{title}}</div>
-  </div>
-  {{#if isDismissible}}
-    <div class="nucleus-inline-banner__close">
-      {{nucleus-button
-        variant="text"
-        size="mini"
-        icon="nucleus-cross"
-        iconOnly=true
-        onClick=(action "onCloseTip")}}
+<div class="nucleus-inline-banner__icon">
+  {{nucleus-icon name=_icon size="medium" variant=type}}
+</div>
+<div class="nucleus-inline-banner__content">
+  {{#if hasBlock}}
+    {{yield}}
+  {{else}}
+    <div data-test-id="nucleus-inline-banner-title">
+      {{title}}
     </div>
   {{/if}}
+</div>
+{{#if isDismissible}}
+  <div class="nucleus-inline-banner__close">
+    {{nucleus-button
+      variant="text"
+      size="mini"
+      icon="nucleus-cross"
+      iconOnly=true
+      onClick=(action "onCloseTip")}}
+  </div>
 {{/if}}