[FS-154088]: node 16 requisite changes in freshservice #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dency of ember-cli-sass and sasscompiler should be installed by user as part of package upgrade
SivaSathyamurthy
changed the title
preethi-sathiyanarayanan
suggested changes
Jul 2, 2024
| @@ -46,7 +46,8 @@ | |||
| "ember-resolver": "^4.5.5", | |||
| "ember-source": "2.18.2", | |||
| "eslint-plugin-ember-suave": "^1.0.0", | |||
| "loader.js": "^4.6.0" | |||
| "loader.js": "^4.6.0", | |||
| "sass": "^1.77.6" | |||
There was a problem hiding this comment.
Add details and screenshots explaining the need for this change
There was a problem hiding this comment.
vigneshk-fd
approved these changes
Jul 11, 2024
sreeram-cv
approved these changes
Aug 28, 2024
|
please add reason why no impact here and in itil PR
|
Reference screenshot Ref doc 2) npm ls screenshot comparision: - v16.20.2 - v12.19.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node 16 requisite changes in freshservice