Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete request lib because it's not being used #29

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

shannonwells
Copy link

@shannonwells shannonwells commented Sep 30, 2024

The faucet is actually not even using the deprecated request package. So it's removed from package.json. I tested only with a localhost against a local chain, because the request package was originally used only by the faucet server.

Closes #24

To verify

  1. first launch a local frequency chain.
  2. launch the server
git fetch -ftp
git co feat/replace-request
yarn install --frozen-lockfile && yarn dev
  1. launch the client in another terminal
cd client
yarn install --frozen-lockfile && yarn dev -- --open
  1. Fill in the faucet form with a valid address and submit.
  2. Verify that the address receives 10 UNIT

@shannonwells shannonwells marked this pull request as ready for review September 30, 2024 22:10
@shannonwells shannonwells changed the title Delete request lib because we're not using it Delete request lib because it's not being used Sep 30, 2024
@shannonwells shannonwells merged commit 46028e8 into main Oct 1, 2024
6 checks passed
@shannonwells shannonwells deleted the feat/replace-request branch October 1, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace request with a suitable alternative
2 participants