Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timestamps verification: verify against relay slots #2221

Merged
merged 8 commits into from
Nov 26, 2024
Merged

timestamps verification: verify against relay slots #2221

merged 8 commits into from
Nov 26, 2024

Conversation

saraswatpuneet
Copy link
Collaborator

@saraswatpuneet saraswatpuneet commented Nov 13, 2024 •
edited
Loading

Verify timestamps against relay chain slot numbers via OnTimestampSet.

Closes #2219

Discussion

Solution proposed in story above

Checklist

  • Updated Pallet Readme?
  • Updated js/api-augment for Custom RPC APIs?
  • Design doc(s) updated?
  • Unit Tests added?
  • e2e Tests added?
  • Benchmarks added?
  • Spec version incremented?

@saraswatpuneet
Verify timestamps
f4e79ac 
against relay chain slot numbers via `OnTimestampSet`.
@saraswatpuneet
update spec version
fbd8ca8
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

enddynayn
enddynayn approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@saraswatpuneet saraswatpuneet enabled auto-merge (squash) November 13, 2024 18:49
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Nov 13, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Nov 13, 2024
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Nov 15, 2024
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Nov 15, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Nov 18, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Nov 21, 2024
wilwade
wilwade approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Nov 26, 2024
@saraswatpuneet saraswatpuneet enabled auto-merge (squash) November 26, 2024 17:29
enddynayn
enddynayn approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great!

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Nov 26, 2024
@wilwade wilwade requested a review from aramikm November 26, 2024 19:54
mattheworris
mattheworris approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@saraswatpuneet saraswatpuneet merged commit 4e9a1a2 into main Nov 26, 2024
30 checks passed
@saraswatpuneet saraswatpuneet deleted the ontimestamp_set branch November 26, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enddynayn enddynayn enddynayn approved these changes

@mattheworris mattheworris mattheworris approved these changes

@wilwade wilwade wilwade approved these changes

@aramikm aramikm Awaiting requested review from aramikm

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Fix for pallet_timestamp::Config
5 participants
@saraswatpuneet @wilwade @mattheworris @enddynayn @aramikm