Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Augment update to use metadata v15 #2191

Merged
merged 5 commits into from
Oct 21, 2024
Merged

API Augment update to use metadata v15 #2191

merged 5 commits into from
Oct 21, 2024

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented Oct 21, 2024 •
edited
Loading

Goal

The goal of this PR is to update API Augment to use the newer metadata v15 provided with Polkadotjs/api v 14.1.1

Part of #2154

Discussion

  • Updated the Export Metadata Cmd to use Metadata v15
  • Update the fetch:local to use Metadata v15
  • Fixed a test that doesn't work under all situations (description is not always returned on all networks)
  • Setup e2e testnet workflow to run on the provided branch instead of against the release branch so that other test setups can test against testnet

Testing

  • make js
  • /target/debug/frequency export-metadata --tmp ./js/api-augment/metadata.json && cd js/api-augment && npm run build

@wilwade wilwade requested review from a team, shannonwells, mattheworris and enddynayn and removed request for a team October 21, 2024 15:47
@wilwade wilwade requested a review from demisx as a code owner October 21, 2024 15:47
wilwade
wilwade commented Oct 21, 2024
View reviewed changes
e2e/stateful-pallet-storage/handlePaginated.test.ts
name: 'StalePageState',
section: 'statefulStorage',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message is not always included in the result from testnet due to how the wasm is compressed

enddynayn
enddynayn approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great!

@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Oct 21, 2024
@github-actions github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Oct 21, 2024
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Oct 21, 2024
@wilwade wilwade merged commit 11225b1 into main Oct 21, 2024
27 checks passed
@wilwade wilwade deleted the fix/e2e-update-to-use-metadata-v15 branch October 21, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enddynayn enddynayn enddynayn approved these changes

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@shannonwells shannonwells Awaiting requested review from shannonwells shannonwells was automatically assigned from frequency-chain/pr-reviewers

@mattheworris mattheworris Awaiting requested review from mattheworris mattheworris was automatically assigned from frequency-chain/pr-reviewers

@demisx demisx Awaiting requested review from demisx demisx is a code owner

@aramikm aramikm Awaiting requested review from aramikm aramikm was automatically assigned from frequency-chain/pr-reviewers

@claireolmstead claireolmstead Awaiting requested review from claireolmstead claireolmstead was automatically assigned from frequency-chain/pr-reviewers

@JoeCap08055 JoeCap08055 Awaiting requested review from JoeCap08055 JoeCap08055 was automatically assigned from frequency-chain/pr-reviewers

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilwade @enddynayn @saraswatpuneet