Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(upgrade): v1.6.0 to v1.7.0 #2066

Merged
merged 1 commit into from
Jul 12, 2024
Merged

chore(upgrade): v1.6.0 to v1.7.0 #2066

merged 1 commit into from
Jul 12, 2024

Conversation

enddynayn
Copy link
Collaborator

  • Upgrade Polkadot-sdk to v.1.7.0.
  • Update weights to reflect the new version.

Notable Changes:

For more details, please refer to:

Release Notes

#1870

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jul 10, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.6.0-to-v1.7.0-issue-1870 branch 2 times, most recently from fda9318 to a7b2675 Compare July 10, 2024 23:00
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jul 10, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.6.0-to-v1.7.0-issue-1870 branch from a7b2675 to bfc6f8c Compare July 10, 2024 23:54
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jul 10, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.6.0-to-v1.7.0-issue-1870 branch 2 times, most recently from 711e0cc to d4e48b2 Compare July 11, 2024 20:51
@enddynayn enddynayn marked this pull request as ready for review July 11, 2024 20:52
@enddynayn enddynayn requested a review from wilwade as a code owner July 11, 2024 20:52
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.6.0-to-v1.7.0-issue-1870 branch from d4e48b2 to fe32d17 Compare July 11, 2024 20:58
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Files Coverage Δ
common/helpers/src/rpc.rs 100.00% <100.00%> (ø)
pallets/schemas/src/rpc/src/lib.rs 93.54% <100.00%> (ø)
pallets/schemas/src/serde.rs 100.00% <ø> (ø)
pallets/messages/src/rpc/src/lib.rs 94.44% <80.00%> (-2.44%) ⬇️
pallets/frequency-tx-payment/src/rpc/src/lib.rs 47.50% <33.33%> (ø)
pallets/handles/src/rpc/src/lib.rs 67.50% <0.00%> (-1.74%) ⬇️
pallets/msa/src/rpc/src/lib.rs 87.93% <60.00%> (-2.81%) ⬇️
pallets/stateful-storage/src/rpc/src/lib.rs 85.71% <50.00%> (ø)

... and 1 file with indirect coverage changes

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jul 11, 2024
@enddynayn
chore(upgrade): v1.6.0 to v1.7.0
c6702ac 
- Upgrade Polkadot-sdk to v.1.7.0.
- Update weights to reflect the new version.

Notable Changes:
- [Allow custom error types in Jsonrpsee](paritytech/polkadot-sdk#1313)

For more details, please refer to:

[Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.7.0)

issue-1870
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.6.0-to-v1.7.0-issue-1870 branch from 70bd40c to c6702ac Compare July 11, 2024 22:05
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jul 11, 2024
claireolmstead
claireolmstead reviewed Jul 11, 2024
View reviewed changes
common/helpers/src/rpc.rs
@@ -1,19 +1,19 @@
use core::result::Result as CoreResult;
use jsonrpsee::{
core::{Error as RpcError, RpcResult},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love removing an as

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

claireolmstead
claireolmstead approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve, but I don't feel like I'm qualified enough to understand the purpose of a lot of these changes, specifically in reference to the parts value changes.

Lots of good type changes.

aramikm
aramikm approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I think there might be some questions about how this back-pressure implementation which supports 65 messages per connection by default might have some effects on our apps subscribing to the chain.

shannonwells
shannonwells approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

I reviewed the code, I analyzed the weights changes (w/ chatgpt), I reviewed the linked polkadot-sdk PRs.

pallets/schemas/src/tests/serde_tests.rs Show resolved Hide resolved
saraswatpuneet
saraswatpuneet approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through code and comments

Great job 👏🏽

@enddynayn
Copy link
Collaborator Author

enddynayn commented Jul 12, 2024 •
edited
Loading

Looks great!

I think there might be some questions about how this back-pressure implementation which supports 65 messages per connection by default might have some effects on our apps subscribing to the chain.

Thanks! Thats a good point. Ill create an issue so that we can properly configure backpressure.

#2072

@enddynayn enddynayn merged commit 9affb5a into main Jul 12, 2024
27 checks passed
@enddynayn enddynayn deleted the chore/upgrade-polkadot-v1.6.0-to-v1.7.0-issue-1870 branch July 12, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@claireolmstead claireolmstead claireolmstead approved these changes

@aramikm aramikm aramikm approved these changes

@shannonwells shannonwells shannonwells approved these changes

@wilwade wilwade Awaiting requested review from wilwade wilwade is a code owner

@mattheworris mattheworris Awaiting requested review from mattheworris

@JoeCap08055 JoeCap08055 Awaiting requested review from JoeCap08055

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enddynayn @shannonwells @aramikm @claireolmstead @saraswatpuneet