Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore]: Remove pallet::getter Usage from All Pallets #2105

Closed
enddynayn opened this issue Jul 31, 2024 · 0 comments · Fixed by #2111
Closed

[Chore]: Remove pallet::getter Usage from All Pallets #2105

enddynayn opened this issue Jul 31, 2024 · 0 comments · Fixed by #2111
Assignees
@aramikm
Milestone
2024 Q3 Progressi...

Comments

@enddynayn
Copy link
Collaborator

enddynayn commented Jul 31, 2024 •
edited
Loading

Description
We currently have several pallets that use the pallet::getter macro. Since this macro is going to be deprecated soon, it’s a good idea to remove it now and simplify our codebase. The preferred syntax moving forward is to use Key::::get() instead.

Acceptance Criteria

  • No more pallet::getter usage in the codebase.

Polkadot Reference
@aramikm aramikm self-assigned this Aug 2, 2024
@aramikm aramikm mentioned this issue Aug 2, 2024
Merged
@aramikm aramikm closed this as completed in 9919861 Aug 5, 2024
@aramikm aramikm mentioned this issue Aug 5, 2024
Merged
aramikm added a commit that referenced this issue Aug 5, 2024
@aramikm
Boosting: removed added getters (#2112)
65df923 
# Goal
The goal of this PR is to removed added getters

Related to #2105
shannonwells pushed a commit that referenced this issue Oct 9, 2024
@aramikm @shannonwells
Boosting: removed added getters (#2112)
cb037f2 
The goal of this PR is to removed added getters

Related to #2105
shannonwells pushed a commit that referenced this issue Oct 10, 2024
@aramikm @shannonwells
Boosting: removed added getters (#2112)
c60e659 
The goal of this PR is to removed added getters

Related to #2105
shannonwells pushed a commit that referenced this issue Oct 18, 2024
@aramikm @shannonwells
Boosting: removed added getters (#2112)
67ba3c8 
The goal of this PR is to removed added getters

Related to #2105
shannonwells pushed a commit that referenced this issue Oct 25, 2024
@aramikm @shannonwells
Boosting: removed added getters (#2112)
87212e3 
The goal of this PR is to removed added getters

Related to #2105
shannonwells pushed a commit that referenced this issue Oct 29, 2024
@aramikm @shannonwells
Boosting: removed added getters (#2112)
302141b 
The goal of this PR is to removed added getters

Related to #2105
shannonwells pushed a commit that referenced this issue Oct 30, 2024
@aramikm @shannonwells
Boosting: removed added getters (#2112)
e89a577 
The goal of this PR is to removed added getters

Related to #2105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aramikm aramikm

Labels
None yet
Projects
None yet
Milestone
2024 Q3 Progressive Enhancements
Development

Successfully merging a pull request may close this issue.

Removed storage getter frequency-chain/frequency
3 participants
@wilwade @enddynayn @aramikm