Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api Augment npm release should not set RC releases as latest #1776

Closed
wilwade opened this issue Nov 10, 2023 · 0 comments · Fixed by #1777
Closed

Api Augment npm release should not set RC releases as latest #1776

wilwade opened this issue Nov 10, 2023 · 0 comments · Fixed by #1777
Assignees
Labels
ci Continuous integration tech-debt

Comments

@wilwade
Copy link
Collaborator

wilwade commented Nov 10, 2023

When publishing an RC release, CI npm publishing tags the rc release as latest when it should only tag it with the version.

Solution: Remove the latest tag push from CI for RC releases, but maintain the version publishing.

See .github/workflows/release.yml

- name: Release on NPM @latest
   if: env.TEST_RUN != 'true'
   run: npm publish --tag latest --access public

Helpful: if: steps.is-full-release.outputs.is-full-release != 'true'

@wilwade wilwade added ci Continuous integration tech-debt labels Nov 10, 2023
@wilwade wilwade self-assigned this Nov 10, 2023
wilwade added a commit that referenced this issue Nov 13, 2023
…1777)

# Goal
The goal of this PR is to update CI publishing of Api-Augment on RC
releases.

Closes #1776
aramikm pushed a commit that referenced this issue Nov 13, 2023
…1777)

# Goal
The goal of this PR is to update CI publishing of Api-Augment on RC
releases.

Closes #1776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration tech-debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant