Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Release workflow to CI base image #1516

Closed
demisx opened this issue May 10, 2023 · 2 comments · Fixed by #1534
Closed

Switch Release workflow to CI base image #1516

demisx opened this issue May 10, 2023 · 2 comments · Fixed by #1534
Assignees
Labels
blocked Blocked by another issue ci Continuous integration tech debt

Comments

@demisx
Copy link
Collaborator

demisx commented May 10, 2023

Similar to #1500.

Blocked by:

@demisx demisx self-assigned this May 10, 2023
@demisx demisx added tech debt ci Continuous integration labels May 10, 2023
@demisx demisx linked a pull request May 17, 2023 that will close this issue
@demisx demisx added the blocked Blocked by another issue label May 17, 2023
@demisx
Copy link
Collaborator Author

demisx commented May 17, 2023

The “Install Subwasm” step currently fails in CI Release workflow with this error (this may be resolved by #1449):

error[E0658]: sym operands for inline assembly are unstable
--> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/wasmtime-runtime-6.0.1/src/trampolines/x86_64.rs:139:13
|
139 | sym $libcall_impl
| ^^^^^^^^^^^^^^^^^
|
::: /root/.cargo/registry/src/github.com-1ecc6299db9ec823/wasmtime-runtime-6.0.1/src/libcalls.rs:146:5
|
146 | wasmtime_environ::foreach_builtin_function!(libcall);
| ---------------------------------------------------- in this macro invocation
|
= note: see issue #93333 rust-lang/rust#93333 for more information
= help: add #![feature(asm_sym)] to the crate attributes to enable
= note: this error originates in the macro wasm_to_libcall_trampoline which comes from the expansion of the macro wasmtime_environ::foreach_builtin_function (in Nightly builds, run with -Z macro-backtrace for more info)

Here is the failed job: https://github.com/LibertyDSNP/frequency/actions/runs/5006563355/jobs/8972114967

@demisx
Copy link
Collaborator Author

demisx commented May 17, 2023

I've matched most steps in the build-runtimes matrix job of the Release workflow with steps in the verify-build-runtime matrix job in the Verify PR workflow, so the error in the above comment also happens in the Verify PR workflow and can be caught during PR CI run.

https://github.com/LibertyDSNP/frequency/actions/runs/5007053807/jobs/8973161880

demisx added a commit that referenced this issue May 25, 2023
# Goal
The goal of this PR is to switch release workflow to CI base image.

Closes #1516
shannonwells pushed a commit that referenced this issue Apr 16, 2024
# Goal
The goal of this PR is to switch release workflow to CI base image.

Closes #1516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by another issue ci Continuous integration tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant