Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bandtastic.py #309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Bandtastic.py #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions user_data/strategies/Bandtastic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def populate_indicators(self, dataframe: DataFrame, metadata: dict) -> DataFrame

return dataframe

def populate_buy_trend(self, dataframe: DataFrame, metadata: dict) -> DataFrame:
def populate_entry_trend(self, dataframe: DataFrame, metadata: dict) -> DataFrame:
conditions = []

# GUARDS
Expand Down Expand Up @@ -129,7 +129,7 @@ def populate_buy_trend(self, dataframe: DataFrame, metadata: dict) -> DataFrame:

return dataframe

def populate_sell_trend(self, dataframe: DataFrame, metadata: dict) -> DataFrame:
def populate_exit_trend(self, dataframe: DataFrame, metadata: dict) -> DataFrame:
Copy link
Member

@xmatthias xmatthias Apr 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well if we do update this part - then we should follow through with all of the strategy migration guide - which doesn't just include this change - but also others (for example updating the dataframe columns to enter_long instead of buy - just to name one without checking for other points).

Otherwise, it'll become some odd middle-state - which is not guaranteed to work in all instances

conditions = []

# GUARDS
Expand Down