Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional compat and add removed keywords #36

Merged
merged 9 commits into from
Apr 13, 2018
Merged

Conversation

frenic
Copy link
Owner

@frenic frenic commented Apr 12, 2018

  • Removed keywords are added
  • Prefixed values for at-rules and pseudo selectors
  • This PR needs to be merged to fix the missing colons

    csstype/index.d.ts

    Lines 3358 to 3363 in f1206f5

    export type SimplePseudos =
    | "-moz-full-screen"
    | "-webkit-full-screen"
    | ":-moz-any-link"
    | ":-moz-placeholder"
    | ":-moz-read-only"

@frenic frenic changed the title Additional compat Additional compat and add removed keywords Apr 12, 2018
@frenic
Copy link
Owner Author

frenic commented Apr 13, 2018

Not sure about always keeping keywords that has been removed by vendors. Maybe we should remove keywords after a certain time after the vendor removed it if we know which version it was removed from using browser data that contains information when the version was released.

@frenic frenic force-pushed the additional-compat branch from f1206f5 to 9ddc6e1 Compare April 13, 2018 11:12
@frenic frenic merged commit e1af19f into master Apr 13, 2018
@frenic frenic deleted the additional-compat branch April 13, 2018 19:10
@frenic
Copy link
Owner Author

frenic commented Apr 13, 2018

I'll add an issue about that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant