Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SVG properties interfaces #21

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Add SVG properties interfaces #21

merged 1 commit into from
Apr 4, 2018

Conversation

frenic
Copy link
Owner

@frenic frenic commented Apr 4, 2018

Originated from https://svgwg.org/svg2-draft/propidx.html and is a temporarily solution until mdn/data#59 is solved.

Fixes #4

@frenic frenic mentioned this pull request Apr 4, 2018
Closed
@frenic
Copy link
Owner Author

frenic commented Apr 4, 2018

I noticed that some important properties like rx and ry is missing.

@Jessidhia Jessidhia mentioned this pull request Apr 4, 2018
Closed
@frenic
Copy link
Owner Author

frenic commented Apr 4, 2018

Nevermind, I got tricked by #20. I can't find any confirmation that rx and ry are valid SVG style properties.

@pelotom
Copy link
Collaborator

pelotom commented Apr 4, 2018

Wow, looking into this I discovered rx and ry were erroneously added to TypeStyle's CSS properties... by me, over a year ago 😅

@frenic frenic merged commit c69c665 into master Apr 4, 2018
@frenic frenic deleted the svg-properties branch April 4, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frenic @pelotom