-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list_orphaned_database_entities service #752
Add list_orphaned_database_entities service #752
Conversation
Sorry to ask, but how can I pass the label check? |
c615e08
to
9cc7d7e
Compare
@coderabbitai review |
Actions PerformedReview triggered.
|
Warning Rate limit exceeded@frenck has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 16 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughWalkthroughThe update brings a new feature to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
documentation/images/entities/list_orphaned_database_entities.png
is excluded by!**/*.png
Files selected for processing (4)
- custom_components/spook/ectoplasms/homeassistant/services/list_orphaned_database_entities.py (1 hunks)
- custom_components/spook/services.yaml (1 hunks)
- documentation/core_extensions.md (1 hunks)
- documentation/entities.md (1 hunks)
Additional Context Used
LanguageTool (5)
documentation/core_extensions.md (2)
Near line 37: Consider using a different adverb to strengthen your wording.
Context: ...rvices. You can even dynamically create completely new areas on the fly. ::: :::{card} D...
Near line 59: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 1618 characters long)
Context: ... more](misc.md) But wait! There is more! If it doesn't fit in any of the above, ...documentation/entities.md (3)
Near line 144: The phrase ‘a lot of’ might be wordy and overused. Consider using an alternative.
Context: ...an be particularly useful when you have a lot of entities, and you want to hide some of ...
Near line 369: Possible missing preposition found.
Context: ...ll_orphaned_entities ``` ::: ### List all orphaned database entities Mass clean ...
Near line 446: This expression usually appears with a “please” in front of it.
Context: ...ty, or repairs detection; feel free to [let us know in our discussion forums](https://githu...
Additional comments not posted (2)
custom_components/spook/ectoplasms/homeassistant/services/list_orphaned_database_entities.py (2)
32-33
: Ensure the SQL query is optimized for performance, especially if thestates_meta
table is large.
44-47
: Ensure the response format aligns with the expected structure in the Home Assistant frontend.
custom_components/spook/ectoplasms/homeassistant/services/list_orphaned_database_entities.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- custom_components/spook/ectoplasms/homeassistant/services/list_orphaned_database_entities.py (1 hunks)
- custom_components/spook/services.yaml (1 hunks)
- documentation/core_extensions.md (1 hunks)
- documentation/entities.md (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- custom_components/spook/ectoplasms/homeassistant/services/list_orphaned_database_entities.py
- custom_components/spook/services.yaml
Additional Context Used
LanguageTool (6)
documentation/core_extensions.md (3)
Near line 15: Possible missing comma found.
Context: ... on the fly. Enable/disable polling for updates or ignore all discovered integrations. ...
Near line 37: Consider using a different adverb to strengthen your wording.
Context: ...rvices. You can even dynamically create completely new areas on the fly. ::: :::{card} D...
Near line 59: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 1567 characters long)
Context: ... more](misc.md) But wait! There is more! If it doesn't fit in any of the above, ...documentation/entities.md (3)
Near line 144: The phrase ‘a lot of’ might be wordy and overused. Consider using an alternative.
Context: ...an be particularly useful when you have a lot of entities, and you want to hide some of ...
Near line 369: Possible missing preposition found.
Context: ...ll_orphaned_entities ``` ::: ### List all orphaned database entities Mass clean ...
Near line 446: This expression usually appears with a “please” in front of it.
Context: ...ty, or repairs detection; feel free to [let us know in our discussion forums](https://githu...
Quality Gate passedIssues Measures |
8d8dd7b
to
bf135e4
Compare
Quality Gate passedIssues Measures |
Thanks, @gieljnssns 👍 ../Frenck |
Description
I have added a service to list all entities that are in your database and not in Home-Assistant anymore.
If you are open to this PR, I will write some documentation for this.Motivation and Context
When you disable or delete an entity in HA they do not get removed from your database.
So after some time your can free some space in your database
How has this been tested?
I have tested this in the devcontainer.
When I disable some entities and then run this service, the disabled entities get returned as a serviceresponse.
Then you can use this response to
recorder.puge_entities
,keep_days: 0
to remove them from your database.Screenshots (if appropriate):
Types of changes
Checklist