Make AbstractSpookEntityService and AbstractSpookEntityComponentService generic #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
commented
Apr 9, 2024
Comment on lines
-21
to
+25
| async def async_handle_service(self, entity: InputNumber, _: ServiceCall) -> None: | ||
| async def async_handle_service( | ||
| self, | ||
| entity: InputNumber, | ||
| call: ServiceCall, # noqa: ARG002 | ||
| ) -> None: |
There was a problem hiding this comment.
The argument names of overwritten methods should match the ones from the super class.
Mypy does not (yet?) validate this, but pyright does.
Parameter 3 name mismatch: base parameter is named "call", override parameter is named "_"
I believe ruff ARG002 is too strict in this case.
Update Found this old mypy issue: python/mypy#6709
|
frenck
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SSIA
Motivation and Context
Improve typing and fix some issues.
How has this been tested?
--
Types of changes
Checklist